Open
Conversation
wistfulvariable
commented
Mar 23, 2026
Owner
Author
wistfulvariable
left a comment
There was a problem hiding this comment.
The JWT parsing looks good but we should add try/catch around the JSON.parse and atob calls — malformed base64 will throw.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary\n- Validates JWT structure (3 parts)\n- Checks expiry timestamp against current time\n- Returns false for empty/malformed tokens\n\nFixes #1\n\n## Test plan\n- [ ] Unit tests for expired tokens\n- [ ] Unit tests for malformed tokens\n- [ ] Integration test with real JWT