Skip to content

feat: add auth passthrough to all namespace methods#146

Merged
Kamilbenkirane merged 2 commits into
mainfrom
feat/namespace-auth-passthrough
Feb 9, 2026
Merged

feat: add auth passthrough to all namespace methods#146
Kamilbenkirane merged 2 commits into
mainfrom
feat/namespace-auth-passthrough

Conversation

@Kamilbenkirane

Copy link
Copy Markdown
Member

Summary

  • Add auth: Authentication | None = None parameter to every create_client() call site across all domain namespaces
  • Covers all 4 domains (text, images, audio, videos) x all variants (async, sync, stream, sync.stream)

Why

The auth parameter was only passed through in TextNamespace.generate(). All other namespace methods (embed, analyze, speak, edit, generate for other domains, and all sync/stream variants) silently dropped it, making Vertex AI authentication impossible outside of async text generation.

Test plan

  • uv run pytest tests/unit_tests -v

@claude

claude Bot commented Feb 9, 2026

Copy link
Copy Markdown

Code review

No issues found. Checked for bugs and CLAUDE.md compliance.

@Kamilbenkirane Kamilbenkirane merged commit 6f7fcbd into main Feb 9, 2026
11 checks passed
@Kamilbenkirane Kamilbenkirane mentioned this pull request Feb 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant