refactor: extract _content_fields ClassVar to eliminate duplicate _build_metadata() overrides#160
Merged
Conversation
…ild_metadata() overrides Replace 20 identical _build_metadata() method overrides with a single _content_fields ClassVar on APIMixin. Filtering logic is centralized in ModalityClient._build_metadata(). Net reduction of ~140 lines. Closes #155
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
This was referenced Feb 24, 2026
Merged
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_content_fields: ClassVar[set[str]]toAPIMixinwith centralized filtering inModalityClient._build_metadata()_build_metadata()method overrides across providers/protocols with one-line ClassVar declarations_build_metadata()pass-throughs (OpenAI audio, Gradium TTS, ElevenLabs TTS)25 files changed, 75 insertions, 215 deletions.
Closes #155
Test plan
pytest tests/unit_tests/test_provider_api_templates.py— template contract validation passespytest tests/unit_tests/— all 472 unit tests pass