fix: catch UnicodeDecodeError in _handle_error_response#171
Merged
Conversation
json.loads() raises UnicodeDecodeError (not JSONDecodeError) on binary bodies with BOM-like bytes (e.g. 0xff). Add it to the except tuple so the method falls through to the response.text fallback and raises httpx.HTTPStatusError as intended.
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #170
Summary
_handle_error_responsenow catchesUnicodeDecodeErrorfromresponse.json()on binary error bodies0xff, UTF-32-LE BOM, high bytes)Root cause
json.loads()performs BOM detection on raw bytes. When a provider returns a binary error body (e.g.b'\xff ...'),json.loads()raisesUnicodeDecodeError— notJSONDecodeError— which was not in theexcepttuple, causing it to escape instead of the expectedhttpx.HTTPStatusError.Test plan
TestHandleErrorResponsetests verifyhttpx.HTTPStatusErroris raised for binary bodies