refactor: consolidate media constraints via generic base classes#176
Merged
Conversation
Replace 6 near-identical media constraint classes with two generic bases (_MediaConstraint[M] and _MediaListConstraint[M]) that use ClassVar dispatch for artifact type and MimeType generics for type-safe supported_mime_types. Update get_constraint_input_type to use _artifact_type ClassVar fast path instead of __call__ introspection.
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
Member
Author
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. 🤖 Generated with Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_MediaConstraint[M: MimeType]and_MediaListConstraint[M: MimeType]get_constraint_input_typeinio.pyto use_artifact_typeClassVar fast path instead of__call__signature introspectionTest plan
pytest tests/unit_tests/test_constraints.py tests/unit_tests/test_io.py -v— 95/95 passmypy src/celeste/constraints.py src/celeste/io.py— cleanruff check src/celeste/constraints.py src/celeste/io.py— cleanCloses #175