fix: move _transform_output to base _predict pipeline#187
Merged
Kamilbenkirane merged 1 commit intoFeb 25, 2026
Conversation
…dict pipeline Closes #142
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #142
_transform_output()call from each provider's_parse_content()to the base_predict()pipeline inModalityClient, preventing silent structured output failures when new providers forget the call_transform_output()from all 11 text provider_parse_content()methods_transform_outputsignature generic (Contentinstead ofTextContent) to work at the base pipeline levelParameterMapper.parse_outputbase signature toAnyas a pragmatic bridge — tracked for proper generic fix in Make ParameterMapper generic on Content type #186Test plan
TestPredictTransformOutputwith 2 integration tests verifying_predict()applies_transform_outputcorrectly