fix(anthropic): move thinking effort to output_config#295
Merged
Conversation
The Messages API rejects an effort key inside the adaptive thinking
object (thinking.adaptive.effort: Extra inputs are not permitted).
thinking_level now emits {"thinking": {"type": "adaptive"},
"output_config": {"effort": <level>}} instead, which is where the
finalized API accepts it. setdefault on output_config so future
output_config fields (e.g. format) compose.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Setting
thinking_levelon an Anthropic model produces a request the Messages API rejects:ThinkingLevelMapperembeds the effort level inside the thinking object —{"thinking": {"type": "adaptive", "effort": "high"}}— but the finalized API only acceptstypeanddisplaythere. Effort belongs in the top-leveloutput_configparameter.Fix
The mapper now emits:
{"thinking": {"type": "adaptive"}, "output_config": {"effort": "high"}}output_configis written viasetdefaultso future fields (e.g.format) compose. Docstrings updated in both the provider mapper and its text-modality subclass.Verification
make lintclean; pre-push mypy/ruff/bandit hooks pass.make test: 682 passed (with--all-extras; the vertex-routing tests need the google extra installed).