Skip to content

chore: bump version to 0.2.4 and add speech-generation optional dependency#34

Merged
Kamilbenkirane merged 2 commits into
mainfrom
chore/bump-version-0.2.4
Nov 14, 2025
Merged

chore: bump version to 0.2.4 and add speech-generation optional dependency#34
Kamilbenkirane merged 2 commits into
mainfrom
chore/bump-version-0.2.4

Conversation

@Kamilbenkirane

Copy link
Copy Markdown
Member

Bump version to 0.2.4 and add celeste-speech-generation as an optional dependency

@claude

claude Bot commented Nov 14, 2025

Copy link
Copy Markdown

Pull Request Review

Summary

This PR bumps the version from 0.2.2 to 0.2.4 and adds celeste-speech-generation as an optional dependency.


🔍 Code Quality & Best Practices

✅ Positive aspects:

⚠️ Issues identified:

1. Version Jump (0.2.2 → 0.2.4)

The version jumps from 0.2.2 to 0.2.4, skipping 0.2.3. This could indicate:

  • Missing version 0.2.3 in the history, or
  • Intentional skip (which should be documented)

Recommendation: If 0.2.3 was released elsewhere or skipped intentionally, this should be noted in the PR description for clarity.


🐛 Potential Issues

1. Missing Package in Workspace

The celeste-speech-generation package is not present in the packages/ directory (only text-generation and image-generation exist). The pyproject.toml has:

[tool.uv.workspace]
members = ["packages/*"]

[tool.uv.sources]
celeste-text-generation = { workspace = true }
celeste-image-generation = { workspace = true }

Questions:

  • Is celeste-speech-generation a separate PyPI package (not in this monorepo)?
  • If so, does version 0.2.3 exist on PyPI?
  • Should it be added to [tool.uv.sources] if it's a workspace package?

Recommendation: Verify that celeste-speech-generation>=0.2.3 is available from the expected source before merging.

2. Missing pyproject.toml Configuration

If this is a workspace package, additional configuration may be needed:

  • Add to [tool.uv.sources] in pyproject.toml:44
  • Add to pytest pythonpath in pyproject.toml:80-84
  • Add mypy overrides if needed (similar to pyproject.toml:165-180)

🚀 Performance Considerations

No performance concerns - this is a dependency declaration only.


🔒 Security Concerns

Low risk, but considerations:

  • The >=0.2.3 version constraint allows any future version, which could introduce breaking changes or vulnerabilities
  • Recommendation: Consider using more restrictive version constraints like >=0.2.3,<0.3.0 for better stability

🧪 Test Coverage

Missing verification:

  • No test changes to verify the optional dependency works correctly
  • No documentation updates (README.md still doesn't mention speech-generation)

Recommendations:

  1. Add speech-generation to the installation examples in README.md:
    uv add "celeste-ai[speech-generation]" # Speech generation
  2. Verify the dependency can be installed successfully:
    uv add "celeste-ai[speech-generation]"

📋 Action Items

Before merging:

  1. ✅ Verify celeste-speech-generation>=0.2.3 exists and is accessible
  2. ⚠️ Clarify the version jump to 0.2.4 (was 0.2.3 skipped intentionally?)
  3. ⚠️ Confirm whether speech-generation needs workspace configuration
  4. 📝 Update README.md to include speech-generation in installation options
  5. 🧪 Test that the optional dependency installs correctly

Code quality: ⭐⭐⭐⭐ (4/5) - Clean changes, follows conventions, but missing documentation
Completeness: ⭐⭐⭐ (3/5) - Dependency added but lacks documentation and verification


✅ Overall Assessment

The code changes are clean and follow the project's conventions. However, there are questions about the missing celeste-speech-generation package in the workspace and the version jump that should be addressed before merging.

@Kamilbenkirane Kamilbenkirane merged commit 30b912f into main Nov 14, 2025
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant