Skip to content

license: change from Apache 2.0 to MIT and enhance README#65

Merged
Kamilbenkirane merged 2 commits into
mainfrom
license/change-to-mit-and-readme-updates
Dec 7, 2025
Merged

license: change from Apache 2.0 to MIT and enhance README#65
Kamilbenkirane merged 2 commits into
mainfrom
license/change-to-mit-and-readme-updates

Conversation

@Kamilbenkirane

@Kamilbenkirane Kamilbenkirane commented Dec 7, 2025

Copy link
Copy Markdown
Member

Changes

License Change

  • Changed license from Apache 2.0 to MIT (Copyright 2025 Kamil Benkirane)
  • Updated LICENSE file with MIT license text
  • Updated all pyproject.toml files (main and all packages) with MIT license
  • Updated all README.md files with MIT license badges and text

README Enhancements

  • Added GitHub stars, PyPI downloads, and LinkedIn follow badges
  • Added 'The standard library for AI' section with key features
  • Updated Quick Start example (simplified, uses model parameter)
  • Updated Multimodal example (ProductCampaign with flux-2-flex)
  • Added 'Switch providers in one line' comparison section demonstrating Celeste's key differentiator
  • Added 'Install what you need' section
  • Added '15+ providers. Zero lock-in.' section header
  • Reorganized sections for better flow

- Change license from Apache 2.0 to MIT (Copyright 2025 Kamil Benkirane)
- Update all pyproject.toml files (main and packages) with MIT license
- Update all README.md files with MIT license badges and text
- Add GitHub stars, PyPI downloads, and LinkedIn follow badges
- Add 'The standard library for AI' section with key features
- Update Quick Start and Multimodal examples
- Add 'Switch providers in one line' comparison section
- Add 'Install what you need' section
- Reorganize sections for better flow
Resolved conflict in README.md by keeping flux-2-flex model name
@claude

claude Bot commented Dec 7, 2025

Copy link
Copy Markdown

PR Review: License Change from Apache 2.0 to MIT

Overall Assessment

This PR successfully changes the license from Apache 2.0 to MIT and updates documentation across the repository. The changes are well-executed and comprehensive, but there are a few considerations to note.


✅ Strengths

  1. Comprehensive License Update

    • All pyproject.toml files updated consistently (main + 4 packages)
    • All README files updated with correct badge and license text
    • License classifier correctly changed in all pyproject files from "License :: OSI Approved :: Apache Software License" to "License :: OSI Approved :: MIT License"
    • No Apache license headers found in source code (verified)
  2. Documentation Consistency

    • License badges updated consistently across all READMEs
    • Badge color changed from red to yellow (appropriate for MIT)
    • License references in footer sections all updated
  3. README Example Fix

    • Fixed model reference from flux-2-dev to flux-2-flex in multimodal example (README.md:77)
    • This is a good improvement for accuracy

⚠️ Important Considerations

1. Legal/Ownership Concerns

  • Copyright holder changed to "Kamil Benkirane" (LICENSE:3)
  • For a repository that may have contributions from others, ensure you have the legal right to relicense
  • Recommendation: If there are other contributors (check git history), you may need their consent for relicensing, or add "and contributors" to the copyright notice
  • Action Item: Run git shortlog -sn to check if there are multiple contributors who should be consulted

2. License Compatibility

  • Apache 2.0 → MIT is generally safe (MIT is more permissive)
  • However, if the project has dependencies or incorporated code under Apache 2.0, those attributions should be preserved
  • No code headers were found, which is good

3. Version Consideration

  • Current version: 0.2.14 (pyproject.toml:3)
  • Since this is a significant legal change, consider whether this warrants a version bump
  • Being in "Development Status :: 3 - Alpha" provides some flexibility

🔍 Code Quality Review

All changes are documentation-only - no code logic changes, which reduces risk:

✅ No new bugs introduced
✅ No security concerns
✅ No performance impact
✅ No test coverage needed (documentation changes)


📋 Minor Observations

  1. README.md Badge Order (lines 17-25)

    • Consider standardizing badge placement (some use for-the-badge style, others don't)
    • Current mix works but could be more consistent
  2. Consistency Check Passed

    • Verified all 5 README files updated (main + 4 packages) ✅
    • Verified all 5 pyproject.toml files updated ✅
    • LICENSE file properly formatted ✅

🎯 Recommendations

Before Merging:

  1. ✅ Verify you have legal authority to relicense (check contributor list)
  2. ⚠️ Consider adding "and contributors" to copyright if applicable
  3. 📢 Consider announcing this license change to users/community
  4. 📝 Consider adding a CHANGELOG entry noting the license change
  5. 🏷️ Consider whether this should bump version to 0.3.0 (minor) given it's a significant change

Optional Improvements:

  • Add a migration note in the README about the license change
  • Update any external documentation or website references to the license

✨ Conclusion

Verdict: Approve with considerations

The technical execution is excellent - all files are updated correctly and consistently. The main concern is ensuring proper legal authority for the relicense. If you're the sole contributor or have obtained necessary permissions, this is good to merge.

The change from Apache 2.0 to MIT will make the project more accessible and easier to integrate into other projects, which is a positive move for an open-source AI library.

@Kamilbenkirane Kamilbenkirane merged commit 327d4a6 into main Dec 7, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant