This repository was archived by the owner on Nov 7, 2019. It is now read-only.
add support for Read + Write for TcpStream and UnixStream#100
Open
vavrusa wants to merge 1 commit intowithoutboats:masterfrom
Open
add support for Read + Write for TcpStream and UnixStream#100vavrusa wants to merge 1 commit intowithoutboats:masterfrom
vavrusa wants to merge 1 commit intowithoutboats:masterfrom
Conversation
There is no way to convert stream objects to their underlying type, but in some cases it's useful to be able to perform blocking I/O, such as when wrapped in stream that handles WouldBlock error in some way.
yoshuawuyts
force-pushed
the
master
branch
2 times, most recently
from
a989815 to
617f76d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is no way to convert stream objects to their underlying type, but in some cases it's useful to be able to perform blocking I/O, such as when wrapped in stream that handles WouldBlock error in some way.
The specific use case for this is https://github.com/dbcfd/tls-async which works around the issue using
Compat<S>whereS: AsyncRead + AsyncWrite, which implements 0.1 FuturesStream. However this won't work outside of 0.1 executor (e.g. Tokio), which makes the usage with Romio awkward. I'm not sure what's the best solution here, but I would assume reexporting mio interfaces is acceptable. This would allow the depending library to useRead + Writedirectly.