Recompute animation timing on output refresh change - #563
Open
sidewalksndskeletons wants to merge 1 commit into
Open
Recompute animation timing on output refresh change#563sidewalksndskeletons wants to merge 1 commit into
sidewalksndskeletons wants to merge 1 commit into
Conversation
refresh_nsec is only known once an output actually presents a frame, which happens after animation_manager_init() has already run. At that point no output has a valid refresh_nsec yet, so the animation timing gets stuck on the 60Hz fallback until the next config reload. Recompute animation timing whenever an output's reported refresh rate changes (first present after startup, or a runtime change e.g. VRR), so it reflects the real refresh rate immediately instead of waiting for a config reload.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
refresh_nsec is only known once an output actually presents a frame, which happens after animation_manager_init() has already run. At that point no output has a valid refresh_nsec yet, so the animation timing gets stuck on the 60Hz fallback until the next config reload.
Recompute animation timing whenever an output's reported refresh rate changes (first present after startup, or a runtime change e.g. VRR), so it reflects the real refresh rate immediately instead of waiting for a config reload.