Skip to content

Browser Persistence: Standardize Controller, Buttons, and Routes#140

Merged
strouptl merged 10 commits into
masterfrom
browser_persistence_buttons
Oct 1, 2025
Merged

Browser Persistence: Standardize Controller, Buttons, and Routes#140
strouptl merged 10 commits into
masterfrom
browser_persistence_buttons

Conversation

@strouptl

@strouptl strouptl commented Sep 5, 2025

Copy link
Copy Markdown
Collaborator

Changes

  • Move browser persistence actions to dedicated controller
  • Standardize browser persistence routes (post/delete rather than get/post)
  • Use button_to (rather than link_to) for controls to reduce JS dependency
  • Add tests for removing and clearing browser persistence

@strouptl strouptl changed the title Browser Persistence Buttons and HTTP Methods Browser Persistence: Buttons and HTTP methods Sep 5, 2025
@strouptl

strouptl commented Sep 5, 2025

Copy link
Copy Markdown
Collaborator Author

@strzibny, these changes may require users to regenerate their devise_otp controllers/views if they have customized them in their application. I think the changes are needed, but we will need to announce them in the Changelog with the release.

Please let me know if you have any thoughts or comments.

Thanks!

@strouptl

strouptl commented Sep 5, 2025

Copy link
Copy Markdown
Collaborator Author

I don't like the "all_persistence" path name either. Maybe I will change this to "clear_all_browsers" for clarity (still with the DELETE HTTP verb).

@strouptl strouptl force-pushed the browser_persistence_buttons branch 3 times, most recently from f28d70d to 1f50955 Compare October 1, 2025 20:56
@strouptl strouptl force-pushed the browser_persistence_buttons branch from 1f50955 to 20d7504 Compare October 1, 2025 20:58
@strouptl strouptl changed the title Browser Persistence: Buttons and HTTP methods Browser Persistence: Standardize Controller, Buttons, and Routes Oct 1, 2025
@strouptl

strouptl commented Oct 1, 2025

Copy link
Copy Markdown
Collaborator Author

NOTE: I ended up renaming the "all_persistence" to "reset", and moving the actions to a dedicated controller.

@strouptl strouptl merged commit a25e2ba into master Oct 1, 2025
24 checks passed
@strouptl strouptl deleted the browser_persistence_buttons branch October 1, 2025 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant