Skip to content

⚡ Bolt: Optimize O(N^2) timeline.NodeStates lookup inside ApplySimulationOutcomes#269

Open
google-labs-jules[bot] wants to merge 1 commit into
masterfrom
perf/optimize-nodestates-lookup-7923459356031527006
Open

⚡ Bolt: Optimize O(N^2) timeline.NodeStates lookup inside ApplySimulationOutcomes#269
google-labs-jules[bot] wants to merge 1 commit into
masterfrom
perf/optimize-nodestates-lookup-7923459356031527006

Conversation

@google-labs-jules

Copy link
Copy Markdown
Contributor

💡 What: Pre-computed a nodeStatesByNodeId dictionary outside the foreach (var node in Scene.Nodes) loop inside the ApplySimulationOutcomes method.

🎯 Why: Previously, the logic was executing .Where over the entire timeline.NodeStates collection twice for every single node in the network to resolve state and backlogByTraffic. This essentially behaved as an $O(N \times S)$ operation, causing significant UI rendering overhead when playing back timeline steps on large graphs.

📊 Impact: Reduces the time complexity from $O(N \times S)$ to $O(N + S)$, dramatically reducing allocations and improving playback framerate for large simulations.

🔬 Measurement: Validated via MedWNetworkSim.Avalonia.Verification and core tests.


PR created automatically by Jules for task 7923459356031527006 started by @wnj00524

@google-labs-jules

Copy link
Copy Markdown
Contributor Author

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants