Cancellation option is added to Triangulate, Refine and Smooth methods#52
Cancellation option is added to Triangulate, Refine and Smooth methods#52wo80 merged 2 commits intowo80:masterfrom YasarYY:master
Conversation
|
Thanks @YasarYY , cancellation support is a welcome addition! Please remove the Windows specific projects from the solution file. This should make the tests run successfully. |
That's okay. I will look at those projects myself and update the code, if necessary. |
|
Hi Christian, |
|
Alright, this looks good. Do you plan to add cancellation support to the actual triangulation algorithms or is this ready to merge? I wouldn't mind merging the PR the way it is. |
|
I don't intend to make any further implementation, unless it is necessary for some reason. Usage of With current implementation, So, in my opinion this is ready to merge. 😌 |
|
Thanks again for your contribution! |
Triangulation operations are now cancellable. This option comes handy for time-consuming operations. Option added to Triangulate and Refine methods with quality parameter, and to Smooth method.
If no cancellation token is given, which is default, these methods works uncancellable and synchronous.
I didn't implement this functionality to Viewer UI in order not to complicate it. Viewer works the same synchronous way.
A usage example snippet: