More various fixes (F-*)#30

Merged

gasbytes merged 26 commits into

wolfSSL:mainfrom

gasbytes:2026-06-14-findings-fixes

Jun 22, 2026

Commits on Jun 16, 2026

added proper checks against 24 bytes cipher text (aes128/256gcm)
gasbytes
committed
added missing checks in quic.rs against the tag_len, to make sure the cipher text is not malformed
gasbytes
committed
run the quic tests in the ci/cd
gasbytes
committed
added missing checks to validate sample length (quic) before encrypting
gasbytes
committed
reuse a single raw pointer for the in/out buffer in all aead encrypt/decrypt ffi calls to avoid stacked borrows provenance invalidation
gasbytes
committed
fix heap leak of boxed aes/chacha in quic ciphers by freeing the box in aescipher/chachacipher drop and on the aesinit error path
gasbytes
committed
remove derive(copy) from the chachaobject since no code copies it as of now
gasbytes
committed
fix data race in quic aes/chacha ciphers by allocating a fresh wolfcrypt context per encrypt/decrypt call instead of mutating shared C state through &self
gasbytes
committed
check returned value of wc_SignatureGetSize
gasbytes
committed
removed sha*hmac modules, since they were merged into src/hmac/mod.rs which implements both
gasbytes
committed
free allocated Hmac object in case of failure from wc_HmacSetKey
gasbytes
committed
make hmacobject own its cleanup via the define_foreign_type_no_copy! macro in src/types/mod.rs
gasbytes
committed
removed manual free that was skipped on panic, using again the automatic drop calls via src/types/mod.rs
gasbytes
committed
make error clearer when expanding a slice in expand_block in hkdf.rs
gasbytes
committed
remove duplicate entry of RSA_PKCS1_SHA512 from the ALGORITHMS slice
gasbytes
committed

Commits on Jun 17, 2026

Commits on Jun 19, 2026

address review: format and print actual_sig_size instead of ret when wc_SignatureGetSize fails
gasbytes
committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

More various fixes (F-*)#30

More various fixes (F-*)#30
gasbytes merged 26 commits into
wolfSSL:mainfrom
gasbytes:2026-06-14-findings-fixes

Commits on Jun 16, 2026

added proper checks against 24 bytes cipher text (aes128/256gcm)

added missing checks in quic.rs against the tag_len, to make sure the cipher text is not malformed

run the quic tests in the ci/cd

added missing checks to validate sample length (quic) before encrypting

reuse a single raw pointer for the in/out buffer in all aead encrypt/decrypt ffi calls to avoid stacked borrows provenance invalidation

fix heap leak of boxed aes/chacha in quic ciphers by freeing the box in aescipher/chachacipher drop and on the aesinit error path

remove derive(copy) from the chachaobject since no code copies it as of now

fix data race in quic aes/chacha ciphers by allocating a fresh wolfcrypt context per encrypt/decrypt call instead of mutating shared C state through &self

check returned value of wc_SignatureGetSize

removed sha*hmac modules, since they were merged into src/hmac/mod.rs which implements both

free allocated Hmac object in case of failure from wc_HmacSetKey

make hmacobject own its cleanup via the define_foreign_type_no_copy! macro in src/types/mod.rs

removed manual free that was skipped on panic, using again the automatic drop calls via src/types/mod.rs

make error clearer when expanding a slice in expand_block in hkdf.rs

remove duplicate entry of RSA_PKCS1_SHA512 from the ALGORITHMS slice

Commits on Jun 17, 2026

zeroize key material in stored in the stack kx modules and not only in the heap

zeroize der(s) after try_from logic in rsa.rs in case of failure during the importing

zeroize ecdsa exported scalar in case of exit on error in the case of unsupported keys

propage init() failures to callers instead of panicking, so a failed wc_init* surfaces as a retriaviable error

move test related crates from dependencies to dev-dependencies instead

remove unnecessary bitwise copy of RsaKey(s) and its deferencing, use size_of the type directly instead

check the digest size after getting its size from the hash type

remove unnecessary wc_ecc_curve_id call

cargo fmt formatting

Added Ed25519KeyPair to prevent type_complexity warning (cargo clippy) from flagging and to make it more readable

Commits on Jun 19, 2026

address review: format and print actual_sig_size instead of ret when wc_SignatureGetSize fails