Skip to content

low-severity hardening, encode/decode validation, credential/payload zeroization, and SN/example fixes#560

Merged
embhorn merged 54 commits into
wolfSSL:masterfrom
aidangarske:fenrir-low-fixes
Jul 10, 2026
Merged

low-severity hardening, encode/decode validation, credential/payload zeroization, and SN/example fixes#560
embhorn merged 54 commits into
wolfSSL:masterfrom
aidangarske:fenrir-low-fixes

Conversation

@aidangarske

@aidangarske aidangarske commented Jul 10, 2026 •
edited
Loading

Copy link
Copy Markdown
Member 
F-6046, F-6219, F-6483, F-6482, F-3389, F-6653, F-4774, F-4930, F-4998, F-4999, F-2025, F-6049, F-2024, F-2026,
F-2027, F-3830, F-4524, F-6051, F-6657, F-6226, F-6490, F-3822, F-3828, F-2753, F-4055, F-4526, F-4522, F-4525,
F-6489, F-3629, F-2758, F-6048, F-6228, F-5507, F-5667, F-6652, F-6218, F-3139, F-3824, F-2759, F-4306, F-4519, 
F-5666, F-5504, F-2361, F-2364, F-2365, F-4521, F-4520, F-6040, F-6041, F-5772, F-3396, F-5770

aidangarske added 29 commits July 9, 2026 22:38
@aidangarske
F-6046 - Reset the SN shared object instead of the generic message ob…
717e53e 
…ject
@aidangarske
F-6219 - Validate exact length in SN_Decode_PublishResp
623b7af
@aidangarske
F-6483 - Bound the SN PINGREQ client id to prevent length narrowing
6bcdace
@aidangarske
F-6482 - Echo the received PUBLISH TopicId in the MQTT-SN PUBACK
8a18f2a
@aidangarske
F-3389 - Skip v5 property-stack shutdown when MqttClient_DeInit gets …
5205fca 
…NULL
@aidangarske
F-6653 - Zero-fill the encoded data field when the payload pointer is…
b8357ba 
… NULL
@aidangarske
F-4774 - Bound assigned client id copy by decoded length in mqttclient
31ff000
@aidangarske
F-4930 - Bound assigned client id copy by decoded length in nbclient
6e76371
@aidangarske
F-4998 - Bound assigned client id copy by decoded length in mqtt-pub
af8123c
@aidangarske
F-4999 - Bound assigned client id copy by decoded length in mqtt-sub
0b77268
@aidangarske
F-2025 - Force-zero broker client credentials on static-memory free
f5326a4
@aidangarske
F-6049 - Wipe the persist AES key cache unconditionally on broker free
ab5f47e
@aidangarske
F-2024 - Force-zero broker will buffers on static-memory ClearWill
392a99d
@aidangarske
F-2026 - Force-zero retained message on static-memory delete
ef1ddfd
@aidangarske
F-2027 - Force-zero retained messages on static-memory free-all
ff9c8e9
@aidangarske
F-3830 - Force-zero pending wills on static-memory cleanup
0fef1f2
@aidangarske
F-4524 - Scrub each subscriber tx_buf after forwarding an immediate will
9519460
@aidangarske
F-6051 - Force-zero retained payloads before free on dynamic-memory p…
db2b3aa 
…aths
@aidangarske
F-6657 - Force-zero broker out-queue payloads before free
a71f43b
@aidangarske
F-6226 - Force-zero decrypted persist payloads before free
bdc73ec
@aidangarske
F-6490 - Force-zero persist serialization buffers before free
9cdcc1e
@aidangarske
F-3822 - Reject reserved QoS in MqttEncode_Publish
80a00b2
@aidangarske
F-3828 - Reject per-topic QoS above 2 in MqttEncode_Subscribe
1e81241
@aidangarske
F-2753 - Reject zero-topic SUBSCRIBE and UNSUBSCRIBE encode
ce373d8
@aidangarske
F-4055 - Require a non-zero packet id in MqttEncode_PublishResp
2ae0159
@aidangarske
F-4526 - Validate the Will Topic name in MqttEncode_Connect
9a753bb
@aidangarske
F-4522 - Reject reserved Will QoS in MqttEncode_Connect
55e67e1
@aidangarske
F-4525 - Normalize protocol level 0 before encoding CONNECT
58860cd
@aidangarske
F-6489 - Reject reserved ConnectAck flag bits
0ade8fc
@aidangarske aidangarske self-assigned this Jul 10, 2026
aidangarske added 16 commits July 10, 2026 10:10
@aidangarske
F-6218 - Treat retain as truthy in the retain-availability guard
6f36226
@aidangarske
F-3139 - Guard property length underflow in MqttDecode_Props
75bb05f
@aidangarske
F-3824 - Reject an over-long remaining-length VBI without an extra so…
b396b96 
…cket read
@aidangarske
F-2759 - Compare broker credentials with a bounded constant-time length
1bcd0bb
@aidangarske
F-4306 - Return Packet-Identifier-Not-Found for untracked QoS2 PUBREL
455707f
@aidangarske
F-4519 - Deliver retained messages using the full subscription filter
ad5b0b3
@aidangarske
F-5666 - Force-zero tx_buf after encoding v5 DISCONNECT
fbfae69
@aidangarske
F-5504 - Scrub tx_buf in MqttClient_CancelMessage
0a65851
@aidangarske
F-2361 - Decode fixed-header remaining length via a typed word32 temp…
06be735 
…orary
@aidangarske
F-2364 - Decode packet-read remaining length via a typed word32 tempo…
763e3ba 
…rary
@aidangarske
F-2365 - Decode property identifier via a typed word32 temporary
6e24875
@aidangarske
F-4521 - Reject a negative cmd_timeout_ms in MqttClient_Init
32b8a5e
@aidangarske
F-4520 - Emit the plaintext-credentials warning in production builds
6f846d9
@aidangarske
F-6040 - Reject a SUBACK whose return-code count differs from topic c…
0c14280 
…ount
@aidangarske
F-6041 - Reject a publish with buffer set but zero total length
539709a
@aidangarske
F-5772 - Stream signed firmware from memory to close fwpush reopen TO…
cead46f 
…CTOU
@aidangarske aidangarske marked this pull request as ready for review July 10, 2026 17:12
@aidangarske aidangarske assigned embhorn and unassigned aidangarske Jul 10, 2026
@aidangarske aidangarske requested a review from embhorn July 10, 2026 18:06
embhorn
embhorn requested changes Jul 10, 2026
View reviewed changes

@embhorn embhorn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just fix up the one comment

Comment thread examples/firmware/fwpush.c Outdated
@aidangarske aidangarske requested a review from embhorn July 10, 2026 20:55
@embhorn embhorn merged commit 6b54d32 into wolfSSL:master Jul 10, 2026
45 checks passed
@aidangarske aidangarske deleted the fenrir-low-fixes branch July 10, 2026 21:10
@embhorn embhorn mentioned this pull request Jul 13, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments
@embhorn embhorn embhorn approved these changes

Assignees

@embhorn embhorn

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@aidangarske @embhorn