Drop incorrect const from ForceZero mem argument#1106
Open
ejohnstown wants to merge 1 commit into
Open
Conversation
ForceZero writes zeros through mem, so const void* wasn't the right kind of pointer to take. It worked because of the casting later.
wolfSSL-Fenrir-bot
left a comment
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #1106
Scan targets checked: wolfssh-bugs, wolfssh-src
No new issues found in the changed files. ✅
Contributor
There was a problem hiding this comment.
Pull request overview
This PR corrects the ForceZero function signature to reflect that it writes to the provided memory buffer, by removing the incorrect const qualifier from the mem parameter.
Changes:
- Update
ForceZerodeclaration inwolfssh/misc.hfromconst void*tovoid*. - Update
ForceZerodefinition insrc/misc.cfromconst void*tovoid*.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| wolfssh/misc.h | Adjusts the ForceZero prototype so callers must provide a writable buffer. |
| src/misc.c | Keeps the implementation consistent with the corrected writable-buffer signature. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ForceZero writes zeros through mem, so const void* wasn't the right kind of pointer to take. It worked because of the casting later.