Add a bounds check on ff_close, ff_pwrite and ff_pread#904
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds defensive bounds checks for FatFS-backed file descriptor pool access to prevent out-of-range indexing in the WolfSSH SFTP FatFS port.
Changes:
- Add
fdrange validation inff_close. - Add
fdrange validation inff_pwrite/ff_preadbefore dereferencingfd_pool[fd]. - Refactor
FIL* finitialization so it occurs after the new bounds checks.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
dgarske
approved these changes
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the bound check into ff_close, ff_pwrite and ff_pread implemented in src/wolfsftp.c.