Skip to content

Zero AllocKey's allocation so its failure path cannot free garbage #10873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
PhilipTaronQ wants to merge 1 commit into from
+5 −0
Closed

Zero AllocKey's allocation so its failure path cannot free garbage #10873

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/internal.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8537,6 +8537,11 @@ int AllocKey(WOLFSSL* ssl, int type, void** pKey)
return MEMORY_E;
}

/* Zero the key so the failure path below can run the type's free
* function even when its init function failed before initializing
* anything: freeing an uninitialized key walks garbage lengths. */
XMEMSET(*pKey, 0, sz);

/* Initialize key */
switch (type) {
#ifndef NO_RSA
Expand Down