20260710-linuxkm-fixes#10881
Open
douzzer wants to merge 4 commits into
Open
Conversation
…efault (apparently unneeded with make 4.4.1 and current Makefile/Kbuild).
…esGcmSetExtIV() and wc_AesGcmEncrypt_ex(), not wc_AesGcmEncrypt(), to stay inside FIPS boundary.
…ttempted re-registration of callback.
…_aes.c, tests/api/test_aes.c: fixes for AF_ALG and KCAPI ports. fixes longstanding bug in afalg_aes.c that made no-AAD handles non-interchangeable with AAD handles. also adds missing arg validation and KEYUSAGE_E checks throughout AF_ALG.
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #10881
Scan targets checked: linuxkm-bugs, linuxkm-src, wolfcrypt-port-bugs, wolfssl-bugs, wolfssl-src
No new issues found in the changed files. ✅
Contributor
Author
|
retest this please |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
linuxkm/Makefile: move--no-silentkludge into$(NO_SILENT), off by default (apparently unneeded with make 4.4.1 and currentMakefile/Kbuild).linuxkm/lkcapi_aes_glue.c: in non-streamingAesGcmCrypt_1(), usewc_AesGcmSetExtIV()andwc_AesGcmEncrypt_ex(), notwc_AesGcmEncrypt(), to stay inside FIPS boundary.tests/api.c: fixtest_wc_CryptoCb_registry()for newALREADY_Efrom attempted re-registration of callback.wolfcrypt/src/port/af_alg/afalg_aes.c,wolfcrypt/src/port/kcapi/kcapi_aes.c,tests/api/test_aes.c: fixes forAF_ALGand KCAPI ports.(fixes longstanding bug in
afalg_aes.cthat made no-AAD handles non-interchangeable with AAD handles. also adds missing arg validation andKEYUSAGE_Echecks throughout AF_ALG.)detected by and tested with