Use safe sum in PKCS7_VerifySignedData.#10882
Open
kareem-wolfssl wants to merge 3 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot couldn't run its full agentic review because no GitHub Actions runner was available. Make sure your repository has a runner available to run Copilot's review, or add a copilot-setup-steps.yml file specifying one with the runs-on attribute. See the docs for more details.
Adds overflow-safe arithmetic when computing certificate length fields during PKCS#7 SignedData verification to address zd#22137.
Changes:
- Replace direct signed additions to
length/certSzwithWC_SAFE_SUM_SIGNEDchecks. - Set error codes when overflow is detected (and break out in one of the two sites).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
7644
to
7648
| if (!WC_SAFE_SUM_SIGNED(int, length, | ||
| (int)(localIdx - certIdx), length)) { | ||
| ret = ASN_PARSE_E; | ||
| } | ||
| idx = certIdx; |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes zd#22137
Testing
Built in tests + provided reproducer
Checklist