Adjust wolfEntropy size calculation and error out if an invalid combination of settings is given.#10884
Open
kareem-wolfssl wants to merge 1 commit into
Open
Adjust wolfEntropy size calculation and error out if an invalid combination of settings is given.#10884kareem-wolfssl wants to merge 1 commit into
kareem-wolfssl wants to merge 1 commit into
Conversation
…nation of settings is given.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the compile-time sizing logic for the wolfentropy.c MemUse entropy state buffer to ensure Entropy_MemUse()’s computed indices remain in-bounds across a wider range of ENTROPY_* macro configurations, and adds configuration validation to fail fast on clearly invalid settings.
Changes:
- Add a compile-time error when
ENTROPY_NUM_UPDATES < 1. - Replace the previous coarse
EXTRA_ENTROPY_WORDSsizing heuristic with an exact overflow calculation based onEntropy_MemUse()’s maximum possible index. - Add an additional compile-time sanity check that errors out if the computed sizing is internally inconsistent.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes zd#22127
Testing
Built in tests, provided test cases
Checklist