[WIP][bugfix] corrected carriage return bug for specific sys_log() call#45
Open
PThierry wants to merge 1 commit intowookey-project:masterfrom
Open
[WIP][bugfix] corrected carriage return bug for specific sys_log() call#45PThierry wants to merge 1 commit intowookey-project:masterfrom
PThierry wants to merge 1 commit intowookey-project:masterfrom
Conversation
PThierry
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Type:
Rationale:
Ideally, the kernel should not patch the message string itself. The userspace message string is prefixed with the task name in order to increase the readability of the overall log interface, but the message string may include 0, 1, or multiple newlines. Each of them should be handled properly (meaning adding the carriage return char, as the output is a serial console). No other modification should be done (adding carriage if there is no newline for e.g.)