Skip to content

Change var to const#18

Open
1shaked wants to merge 1 commit intowoothee:masterfrom
1shaked:patch-1
Open

Change var to const#18
1shaked wants to merge 1 commit intowoothee:masterfrom
1shaked:patch-1

Conversation

@1shaked
Copy link
Copy Markdown

@1shaked 1shaked commented May 31, 2021

The best practice of using const where var is not going to change in the next pull request I will also add optional changing to avoid can not read property of undefined

The best practice of using const where var is not going to change in the next pull request I will also add optional changing to avoid can not read property of undefined
@1shaked
Copy link
Copy Markdown
Author

1shaked commented Sep 5, 2021

is this repo still active??

@tagomoris
Copy link
Copy Markdown
Member

This is still active. I didn't see the detail of this change because the CI was failing.

@1shaked
Copy link
Copy Markdown
Author

1shaked commented Sep 6, 2021

The ci was failing automatically, you can the the file changes and what I changed just by clicking on the commit

@1shaked
Copy link
Copy Markdown
Author

1shaked commented Sep 6, 2021

like var msiePattern = /MSIE ([.0-9]+);/;
var tridentPattern = /Trident/[.0-9]+;/;
var tridentVersionPattern = / rv:([.0-9]+)/;
var iemobilePattern = /IEMobile/([.0-9]+);/;
to this
const msiePattern = /MSIE ([.0-9]+);/;
const tridentPattern = /Trident/[.0-9]+;/;
const tridentVersionPattern = / rv:([.0-9]+)/;
const iemobilePattern = /IEMobile/([.0-9]+);/;

@tagomoris
Copy link
Copy Markdown
Member

@1shaked Could you rebase this branch on the current master (after #21 )?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants