Open
Conversation
The best practice of using const where var is not going to change in the next pull request I will also add optional changing to avoid can not read property of undefined
Author
|
is this repo still active?? |
Member
|
This is still active. I didn't see the detail of this change because the CI was failing. |
Author
|
The ci was failing automatically, you can the the file changes and what I changed just by clicking on the commit |
Author
|
like var msiePattern = /MSIE ([.0-9]+);/; |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The best practice of using const where var is not going to change in the next pull request I will also add optional changing to avoid can not read property of undefined