Do not open new keyboard when Pin lock screen field gets the focus#31
Merged
Do not open new keyboard when Pin lock screen field gets the focus#31
Conversation
… only way I know to completely hide a soft keyboard, even when the user force the focus on it by tapping the field.
Contributor
Author
|
By the way, I know the cursor is not even displayed in the EditField when |
Contributor
|
This addresses the issue but also introduces a new security issue wherein the input in the EditText is not hidden. I've found that if we use instead of setting the input type to |
…s is the only way I know to completely hide a soft keyboard, even when the user force the focus on it by tapping the field." This reverts commit 0b6e239.
…eld. This is the only way I know to completely hide a soft keyboard, even when the user force the focus on it by tapping the field."" This reverts commit 5f37323.
…on focusable, non clickable. Props @tonyr59h
Contributor
Author
|
Thanks @tonyr59h. This is ready for another review. |
Contributor
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #30 by setting the input content type of
TYPE_NULLon thepin_fieldEditText.I tried different ways of hiding the keyboard, but this was the only way that worked fine.
Note: You have to test this on a real device, since you can't repro the original issue on emulators.
Once this PR is merged, we should publish a new version of the library and update the main wp-android prj.