Skip to content

Support editing custom posts #25208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
crazytonyli merged 14 commits into from
Feb 16, 2026
Merged

Support editing custom posts #25208

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
b8bc47a
Add a replacement of SimpleGBKEditorViewController
crazytonyli Feb 3, 2026
3342aa9
Update wordpress-rs and GutenbergKit
crazytonyli Feb 3, 2026
60d5efa
Add navigation bar buttons to Custom Post Editor
crazytonyli Feb 4, 2026
49d0a31
Remove the loading cached dependencies based on post type check
crazytonyli Feb 4, 2026
0be81b3
Send notifications when `FeatureFlagOverrideStore` changes
crazytonyli Feb 9, 2026
8a4c6b0
Pre-fetch editor dependencies for custom post types
crazytonyli Feb 9, 2026
8ac613c
Fix post editor navigation bar padding
crazytonyli Feb 10, 2026
856c97c
Fix feature flag observer
crazytonyli Feb 10, 2026
84fe180
Use a weak reference
crazytonyli Feb 10, 2026
ae4dca3
Localize a couple of strings
crazytonyli Feb 10, 2026
0376d7e
Extract post editor strings
crazytonyli Feb 11, 2026
41807d8
Fix a swiftlint issue
crazytonyli Feb 11, 2026
79c2936
Merge branch 'trunk' into prototype-custom-post-types-local
crazytonyli Feb 13, 2026
b167166
Update GutenbergKit
crazytonyli Feb 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions Modules/Package.resolved
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion Modules/Package.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ let package = Package(
.package(url: "https://github.com/wordpress-mobile/wpxmlrpc", from: "0.9.0"),
.package(url: "https://github.com/wordpress-mobile/NSURL-IDN", revision: "b34794c9a3f32312e1593d4a3d120572afa0d010"),
.package(url: "https://github.com/zendesk/support_sdk_ios", from: "8.0.3"),
.package(url: "https://github.com/wordpress-mobile/GutenbergKit", from: "0.13.2"),
.package(url: "https://github.com/wordpress-mobile/GutenbergKit", revision: "c60333ebf4bd37eafc8981cfc8387b71bdfa5dcc"),
Copy link
Copy Markdown
Member

@dcalhoun dcalhoun Feb 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@crazytonyli before merging, we should publish and integrate a GBK prerelease rather than a Git hash, if possible. This currently points to a commit in an unmerged GBK PR.

// We can't use wordpress-rs branches nor commits here. Only tags work.
.package(url: "https://github.com/Automattic/wordpress-rs", revision: "alpha-20260210"),
.package(
Expand Down
12 changes: 6 additions & 6 deletions Tests/KeystoneTests/Tests/Features/Gutenberg/EditorConfigurationTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ struct EditorConfigurationTests {
.with(dotComID: 12345)
.build()

let config = EditorConfiguration(blog: blog)
let config = EditorConfiguration(blog: blog, postType: .post)

#expect(config.siteApiRoot == URL(string: "https://public-api.wordpress.com/")!, "Should use WP.com API root")
#expect(config.authHeader == "Bearer simple-bearer-token", "Should use Bearer authentication from account")
Expand All @@ -46,7 +46,7 @@ struct EditorConfigurationTests {
.with(url: "https://atomic.com")
.build()

let config = EditorConfiguration(blog: blog)
let config = EditorConfiguration(blog: blog, postType: .post)

#expect(config.siteApiRoot == URL(string: "https://public-api.wordpress.com/")!, "Should use WP.com API root")
#expect(config.authHeader == "Bearer atomic-bearer-token", "Should use Bearer authentication")
Expand All @@ -65,7 +65,7 @@ struct EditorConfigurationTests {
.withApplicationPassword("test-app-password-1234", using: keychain)
.build()

let config = EditorConfiguration(blog: blog, keychain: keychain)
let config = EditorConfiguration(blog: blog, postType: .post, keychain: keychain)
let base64Credentials = "YXRvbWljdXNlcjp0ZXN0LWFwcC1wYXNzd29yZC0xMjM0" // Base64 encoding of "atomicuser:test-app-password-1234"

#expect(config.siteApiRoot == URL(string: "https://67890.example.com/wp-json/")!, "Should use self-hosted API URL")
Expand All @@ -86,7 +86,7 @@ struct EditorConfigurationTests {
.with(restApiRootURL: "https://self-hosted.org/wp-json/")
.build()

let config = EditorConfiguration(blog: blog, keychain: keychain)
let config = EditorConfiguration(blog: blog, postType: .post, keychain: keychain)
let base64Credentials = "c2VsZmhvc3RlZHVzZXI6dGVzdC1hcHAtcGFzc3dvcmQtMTIzNA==" // Base64 encoding of "selfhosteduser:test-app-password-1234"

#expect(config.siteApiRoot == URL(string: "https://self-hosted.org/wp-json/")!, "Should use self-hosted API URL")
Expand All @@ -106,7 +106,7 @@ struct EditorConfigurationTests {
.with(url: "https://self-hosted.org")
.build()

let config = EditorConfiguration(blog: blog, keychain: keychain)
let config = EditorConfiguration(blog: blog, postType: .post, keychain: keychain)

#expect(config.siteApiRoot == URL(string: "https://public-api.wordpress.com/"), "Should use WP.com API root")
#expect(config.authHeader == "Bearer self-hosted-bearer-token", "Should use Bearer authentication")
Expand All @@ -127,7 +127,7 @@ struct EditorConfigurationTests {
.with(restApiRootURL: "https://self-hosted.org/wp-json/")
.build()

let config = EditorConfiguration(blog: blog, keychain: keychain)
let config = EditorConfiguration(blog: blog, postType: .post, keychain: keychain)
let base64Credentials = "c2VsZmhvc3RlZHVzZXI6dGVzdC1hcHAtcGFzc3dvcmQtMTIzNA==" // Base64 encoding of "selfhosteduser:test-app-password-1234"

#expect(config.siteApiRoot == URL(string: "https://self-hosted.org/wp-json/"), "Should use self-hosted API URL")
Expand Down
14 changes: 14 additions & 0 deletions WordPress/Classes/Utility/BuildInformation/FeatureFlagOverrideStore.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,9 @@ protocol OverridableFlag: CustomStringConvertible {
/// Used to override values for feature flags at runtime in debug builds
///
struct FeatureFlagOverrideStore {
static let didChangeNotification = Notification.Name("FeatureFlagOverrideStore.didChange")
static let notificationFeatureFlagKey = "featureFlag"

private let store: KeyValueDatabase

init(store: KeyValueDatabase = UserDefaults.standard) {
Expand All @@ -36,10 +39,13 @@ struct FeatureFlagOverrideStore {
if value != featureFlag.originalValue {
store.set(value, forKey: key)
}

postDidChangeNotification(for: featureFlag)
}

func removeOverride(for featureFlag: OverridableFlag) {
store.removeObject(forKey: featureFlag.key)
postDidChangeNotification(for: featureFlag)
}

/// - returns: The overridden value for the specified feature flag, if one exists.
Expand All @@ -58,6 +64,14 @@ struct FeatureFlagOverrideStore {
return nil
}
}

private func postDidChangeNotification(for featureFlag: OverridableFlag) {
NotificationCenter.default.post(
name: Self.didChangeNotification,
object: nil,
userInfo: [Self.notificationFeatureFlagKey: featureFlag]
)
}
}

enum FeatureFlagError: Error {
Expand Down
2 changes: 1 addition & 1 deletion WordPress/Classes/Utility/Editor/EditorConfiguration+Blog.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import WordPressShared
import Support

extension EditorConfiguration {
init(blog: Blog, postType: String = "post", keychain: KeychainAccessible = KeychainUtils()) {
init(blog: Blog, postType: PostTypeDetails, keychain: KeychainAccessible = KeychainUtils()) {
let selfHostedApiUrl = blog.restApiRootURL ?? blog.url(withPath: "wp-json/")
let applicationPassword = try? blog.getApplicationToken(using: keychain)
let shouldUseWPComRestApi = applicationPassword == nil && blog.isAccessibleThroughWPCom()
Expand Down
Loading