Closed
Conversation
AliSoftware
reviewed
Mar 30, 2026
|
|
||
| ### Bug Fixes | ||
|
|
||
| - Added optional `next_version` parameter to `android_update_release_notes` and `ios_update_release_notes` actions, allowing callers to provide the next version directly instead of relying on the built-in calculator that assumes minor version caps at 9. This fixes incorrect version bumps (e.g., 8.9 → 9.0 instead of 8.10) for apps using semantic versioning. [#706] |
Contributor
There was a problem hiding this comment.
A bit pedantic of me, but while this is a bugfix (which is why it was considered being a patch semver bump)… in practice the fix for the bug consisted of adding a new parameter to the action and thus changing the API (even if in a backwards-compatible way), so IMHO that should be a minor version bump, not a patch for that reason.
Contributor
Author
There was a problem hiding this comment.
Haha, I thought exactly about it right after I ran rake new_version and wondered the same 😄 oh well. Let's do it properly.
Contributor
Author
|
Closing in favor of a minor version bump (14.3.0) since the change adds a new parameter. |
Contributor
Author
|
Moved to #708 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Releasing new version 14.2.1.
What's Next
PR Author: Be sure to create and publish a GitHub Release pointing to
trunkonce this PR gets merged,copy/pasting the following text as the GitHub Release's description: