Expose in-flight Request via optional 'request' option callback#45
Open
owner888 wants to merge 2 commits into
Open
Expose in-flight Request via optional 'request' option callback#45owner888 wants to merge 2 commits into
owner888 wants to merge 2 commits into
Conversation
…equire explicit keep-alive header
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Expose the in-flight
Requestobject to callers via an optional'request'option callback:Why
There is currently no way to cancel an in-flight request. For long-running streaming
responses (e.g. LLM SSE streaming via webman/openai), when the downstream client
disconnects, the upstream request keeps running to completion — wasting resources
(and paid LLM tokens).
With the
Requesthandle exposed, callers can close the underlying connection to abort.Notes
'request'option is set.Request,so the caller always holds the live handle.