Skip to content

Fix connection pool reuse: HTTP/1.1 is persistent by default (RFC 7230) #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
owner888 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix connection pool reuse: HTTP/1.1 is persistent by default (RFC 7230) #46

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions src/Client.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -279,8 +279,16 @@ public function recycleConnectionFromRequest(Request $request, ?Response $respon
$connection->onConnect = $connection->onClose = $connection->onMessage = $connection->onError = null;
$request_header_connection = strtolower($request->getHeaderLine('Connection'));
$response_header_connection = $response ? strtolower($response->getHeaderLine('Connection')) : '';
// Close Connection without header Connection: keep-alive
if ('keep-alive' !== $request_header_connection || 'keep-alive' !== $response_header_connection || $request->getProtocolVersion() !== '1.1') {
// RFC 7230 §6.3: HTTP/1.1 connections are persistent by default — servers usually OMIT
// the Connection header. Close only when either side explicitly says "close", the
// protocol is not 1.1, or there is no response (transport-level failure).
// (Previously required both sides to literally send "Connection: keep-alive", which
// almost never happens with real-world servers, so the pool never reused connections.)
$shouldClose = !$response
|| $request->getProtocolVersion() !== '1.1'
|| str_contains($request_header_connection, 'close')
|| str_contains($response_header_connection, 'close');
if ($shouldClose) {
$connection->close();
}
$request->detachConnection($connection);
Expand Down