fix: Directory User Group Filter - #56
Merged
Merged
Conversation
Greptile SummaryThe PR aligns list-filter query parameters with the documented WorkOS API and repairs the single-logout URL parameter contract.
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains. Important Files Changed
Reviews (2): Last reviewed commit: "fix(routes): align list query params wit..." | Re-trigger Greptile |
gjtorikian
changed the title
Four list endpoints read query params the API does not define, so a caller passing the documented name got a silently unfiltered list rather than an error. That is the failure mode a fixture holding one record cannot catch, which is how it survived having tests. /sso/logout takes `token`. Only the Logout Authorize response body names it `logout_token`, and that field is required there, so the asymmetry is deliberate. The new `idp_id` and `email` filters do not enforce the spec's "requires the directory parameter" precondition: its 422 body is generic, and inventing the message would mean fabricating a value the emulator cannot know.
Collaborator
|
thank you! caught a couple of other places in this PR where a similar fix was needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why am I opening this PR?
The official documentation for listing directory users by group calls out the
?directory=<directory_id>&group=<group_id>query parameters.The emulator API incorrectly expects
?directory_id=<>?group_id=<>.Similarly, the list directory groups is documented with
?directory=<>and the emulator API expects?directory_id=<>