Skip to content

feat: allow users to set a custom endpoint#35

Merged
owenvoke merged 4 commits intoworksome:mainfrom
ju5t:frankfurter-custom-endpoint
Mar 25, 2026
Merged

feat: allow users to set a custom endpoint#35
owenvoke merged 4 commits intoworksome:mainfrom
ju5t:frankfurter-custom-endpoint

Conversation

@ju5t
Copy link
Copy Markdown
Contributor

@ju5t ju5t commented Mar 25, 2026

You can deploy with Docker on your own platform. This means you need to be able to override the endpoint on which you will access its API.

@owenvoke let me know if this fits your style or if you want to call it FRANKFURTER_BASE_URL as that's the name of the variable in the provider.

@owenvoke
Copy link
Copy Markdown
Member

Hi @ju5t, please could you name it FRANKFURTER_BASE_URL (and exchange.services.frankfurter.base_url for the config). 👍🏻 Otherwise, this looks good.

Didn't know you can self-host Frankfurter, interesting!

@ju5t
Copy link
Copy Markdown
Contributor Author

ju5t commented Mar 25, 2026

@owenvoke it's now FRANKFURTER_BASE_URL. I changed the test and config names too of course.

@owenvoke owenvoke merged commit eb7f40d into worksome:main Mar 25, 2026
3 of 11 checks passed
@owenvoke
Copy link
Copy Markdown
Member

Thanks!

@ju5t ju5t deleted the frankfurter-custom-endpoint branch March 25, 2026 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants