Update progress bars for layout/save/render midi + other fixes#211
Open
worldwideweary wants to merge 14 commits into
Open
Update progress bars for layout/save/render midi + other fixes#211worldwideweary wants to merge 14 commits into
worldwideweary wants to merge 14 commits into
Conversation
worldwideweary
force-pushed
the
3.x-www-0131-ProgressBarUpdatesAndOtherFixes
branch
from
June 28, 2026 08:43
8fd09b5 to
d27d0aa
Compare
…screen will show load. Rendering MIDI will show as a pop-up if the preference is enabled, capable of being cancelled with cancel button or escape key. All the other progresses will be "baked" in and not optional
Also update printing to file
4.x uses an undo stack to get back to regular quotes if desired. Here I allow ' or " with Ctrl + apostrophe or double quote The flip of start/end was a simple way to make sure that if starting with a " after a full selection that the cursor would be at the beginning and register the proper start quote instead of at the end. MSS4 does this already, but not from this section, so there must be something else going on that fixes it. For now, this works just fine though and should have no repercussions
…t or elements of same type If of the same elemente type, information regarding the first element of that type will be included
…going from hovering to non-hovering to show the score selection info
…ution) but not between this particular version Reason: personal builds get confusing if running multiple times, not knowing for sure which state I'm in if it happens accidentally, while developing. I definitely don't mind having regular 3.7-Evolution running or old 3.6.2 for a quick test here and there, though.
Found this by seeing score layout act funny with the new progress bars The bug is present in 3.6.2 and 3.7-evolution currently. It may also affect other texts like staff text when skipping with alt+right etc, but not sure
worldwideweary
force-pushed
the
3.x-www-0131-ProgressBarUpdatesAndOtherFixes
branch
from
June 29, 2026 08:53
750c7df to
ad3b2f2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Haven't been really sticking with the idea of single concepts for Pull Requests, but it is what it is. This is mainly about the previous progress dialogues.
Update Progress Bars
After getting #210 working, I had the unfortunate occurrence of auto-save pop-up while looking through style settings or something, and then when the pop-up was done, focus went back to the main app rather than the preference settings dialog. And layout occurs after changes, so it was constantly losing focus. This motivated me to get something more subtle, so I decided to go with using a QProgressBar shown in the Status Bar located at the bottom of the screen. Problem there is that there's one instance of needing to be able to cancel during the progression: Rendering MIDI on during load of score or restoring previous session if the property is enabled to allow pre-loading the midi.
Instead of having all these progress options to show or not, this is what'll happen: There's only one option, and that's loading MIDI events on loading a score. Everything else will be automatic:
Score layout, which is practically the whole time-frame for Save, Auto-Save, and Score Opening (and restoring a session). All that goes into a lower progress bar that's in the status bar down below. The Render MIDI will have a title-less pop-up during score-load. And finally, restoring session will show directly inside the pop-up splash screen on startup instead of something separate.
I sped these up because it takes longer than usual on this 200+ paged score:
splash2.mp4
Saving shown on status bar:
saveStatusBar.mp4
Automatic Curly Quotes
For now, in order to get regular vertical slabs, user will have to use CTRL+' or CTRL+". There's no undo-stack like with 4.x version to get the vertical ones. Curly comes automatically:
Beginning Text Editing will update the view to try to include the system's entire top and bottom skyline.
Fixes
Things that should've been in the first place
Splash Screen
Will look different than usual with a blue grey gradient and a cute sub-version: 3.7.1
Aside, it makes me wonder how important it is to layout the score when saving. Can it be omitted to save time? My intuition says probably, but who knows. I may test it to see what happens. Either way, it's kind of neat to see when the score is autosaving. Sometimes if the user has a huge score loaded, it's awkward to not know why there's a seemingly arbitrary hangup during actions etc, and often times it's due to a timed autosave. I wouldn't not want to have these progress bars! Update: it doesn't layout except for saving the thumbnail, which apparently I already removed to save time earlier. For some reason I thought it was still doing a full layout, but it isn't. One thing I wouldn't mind doing here is have the progress bar when opening a score not from restore is to say "Loading Score" rather than "Layout" because again, it's the layout that's taking the 9/10ths of the load time.
List Selection
Oh yeah, one more thing. If a list selection occurs, and the types are all the same, information regarding the first element of the list will display. So like a key signature on a grandstaff for instance will show the information instead of merely "List Selection". Mouse hovering worked anyway for this stuff on this version, so whatever, but still. And if the types are different, the statement says so:
Oh boy:

And if hovering over an item, there now is a text saying "Hovering over" to re-affirm that's what it is instead of a selection
;)