EVM Watcher Security Improvements#4676
EVM Watcher Security Improvements#4676mdulin2 wants to merge 8 commits intowormhole-foundation:mainfrom
Conversation
|
There are a couple of less-than-ideal things here. For the Second, the |
9e622c3 to
eea1015
Compare
djb15
left a comment
There was a problem hiding this comment.
I think the changes are fine, but it's worth running this on a Guardian in testnet first before wider rollout given the code changes are on the critical path
… for EVM watcher.
2441370 to
6954f66
Compare
johnsaigle
left a comment
There was a problem hiding this comment.
Left some suggestions. Overall the changes look good 👍🏻
We support a large number of EVM chains. There are several invariants that we currently rely on that we should probably explicitly check for that we were not. Specifically, we assume that the EVM subscription will return only logs matching the filter. We assume that a failed Tx will not have any logs. New checks have been added below.