Skip to content

ci: Upgrade golangci-lint version to 2.11#4701

Open
johnsaigle wants to merge 7 commits intowormhole-foundation:mainfrom
johnsaigle:golangci-upgrade-2.11
Open

ci: Upgrade golangci-lint version to 2.11#4701
johnsaigle wants to merge 7 commits intowormhole-foundation:mainfrom
johnsaigle:golangci-upgrade-2.11

Conversation

@johnsaigle
Copy link
Copy Markdown
Contributor

@johnsaigle johnsaigle commented Mar 6, 2026 •
edited
Loading

Changes:

  • channelcheck isn't a real linter, so this modifies these instances into commnets
  • Adds exceptions for what look like attacker-controlled URLs, hard-coded API keys, etc.
  • Fixes variable shadowing
  • Workarounds for context cancellation functions that appeared to not get called (e.g. via defer)

djb15
djb15 previously approved these changes Mar 6, 2026
View reviewed changes
Comment thread node/pkg/notary/admincommands.go
@johnsaigle johnsaigle force-pushed the golangci-upgrade-2.11 branch 2 times, most recently from 8b8c862 to b3ee177 Compare March 9, 2026 18:36
bemic
bemic reviewed Mar 10, 2026
View reviewed changes
Comment thread node/cmd/guardiand/adminnodes.go
Comment thread node/cmd/ccq/query_server.go
@johnsaigle johnsaigle force-pushed the golangci-upgrade-2.11 branch from bcd3ecb to fe30fe9 Compare March 13, 2026 14:50
@johnsaigle johnsaigle requested a review from bemic March 16, 2026 11:39
@johnsaigle johnsaigle force-pushed the golangci-upgrade-2.11 branch from a77c924 to 53b71fc Compare March 17, 2026 12:35
@johnsaigle johnsaigle force-pushed the golangci-upgrade-2.11 branch from 53b71fc to 5a4bb75 Compare March 24, 2026 15:12
@johnsaigle johnsaigle force-pushed the golangci-upgrade-2.11 branch from 5a4bb75 to 158836b Compare April 21, 2026 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@djb15 djb15 djb15 left review comments

@panoel panoel Awaiting requested review from panoel panoel is a code owner

@evan-gray evan-gray Awaiting requested review from evan-gray evan-gray is a code owner

@mdulin2 mdulin2 Awaiting requested review from mdulin2 mdulin2 is a code owner

@pleasew8t pleasew8t Awaiting requested review from pleasew8t pleasew8t is a code owner

@fergarrui fergarrui Awaiting requested review from fergarrui

@SEJeff SEJeff Awaiting requested review from SEJeff SEJeff is a code owner

@bemic bemic Awaiting requested review from bemic bemic is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@johnsaigle @djb15 @bemic