node: Update mutex handling in processor#4713
Open
djb15 wants to merge 1 commit intowormhole-foundation:mainfrom
Open
node: Update mutex handling in processor#4713djb15 wants to merge 1 commit intowormhole-foundation:mainfrom
djb15 wants to merge 1 commit intowormhole-foundation:mainfrom
Conversation
johnsaigle
approved these changes
Mar 12, 2026
Contributor
johnsaigle
left a comment
johnsaigle
left a comment
There was a problem hiding this comment.
Makes sense as a change. I think this could break if the control flow is ever altered to continue/return early but hopefully future LLM scans will catch this. 😅
Anyway the current change is an improvement.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves https://github.com/asymmetric-research/wormhole-llm-issues/issues/68.
The previous
deferwasn't actually releasing the mutex during the loop.