Enabling prot and ret paladin classic sims

[DaveAlessi]

Migration of Protection and Retribution Paladin Simulators from SoD to Classic

From what I could tell, the ret and prot paladin sims were not fully migrated over from Season of Discovery (SoD). This PR migrates the prot and ret simulators from SoD to Classic by removing SoD-specific content and ensuring compatibility with Classic mechanics.

Changes Made

Protocol Buffers (proto/paladin.proto)

• Removed Martyrdom = 3 from the PaladinSeal enum (SoD-only seal)
• Removed IsUsingDivineStormStopAttack option (Divine Storm is a SoD rune ability)
• Removed IsUsingCrusaderStrikeStopAttack option (Crusader Strike is a SoD rune ability)
• Kept IsUsingJudgementStopAttack (valid for Classic seal twisting)

Retribution Paladin

• sim/paladin/retribution/retribution.go: Removed Divine Storm and Crusader Strike stop attack fields from the struct
• sim/paladin/retribution/retribution_test.go: Removed Seal of Martyrdom test options, updated tests to use Seal of Righteousness
• ui/retribution_paladin/inputs.ts: Removed Seal of Martyrdom from seal selection options
• ui/retribution_paladin/presets.ts:
  • Updated DefaultOptions to use PaladinSeal.Righteousness
  • Replaced SoD APL presets with new basic_ret.apl.json
• ui/retribution_paladin/apls/basic_ret.apl.json: New Classic-compatible APL using Judgement and seal twisting between SoR/SoC

Protection Paladin

• sim/paladin/protection/protection.go: Removed Divine Storm and Crusader Strike stop attack fields from the struct
• sim/paladin/protection/protection_test.go: Updated tests to use Seal of Righteousness
• ui/protection_paladin/inputs.ts: Removed Seal of Martyrdom from seal selection options
• ui/protection_paladin/presets.ts:
  • Updated DefaultOptions to use PaladinSeal.Righteousness
  • Replaced SoD APL presets with basic_prot.apl.json and p5prot.apl.json
• ui/protection_paladin/apls/basic_prot.apl.json: New Classic-compatible APL
• ui/protection_paladin/apls/p5prot.apl.json: New Classic-compatible APL with defensive cooldowns

Removed SoD APL Files

Deleted Phase 4/5 SoD-specific APL files that referenced SoD rune abilities and spell IDs.

Updated index.html

Updated the index to point to

• href="/classic/retribution_paladin/"
• href="/classic/protection_paladin/"

Test Results

Regenerated TestRetribution.results and TestProtection.results to reflect the updated test configurations. This is the part I'm least sure about, tests initially failed. From what I can tell the failures were expected because all the APLs had to be updated so I used the make update-tests command.

Testing

• All tests pass (make test)
• Frontend builds successfully (make)
• Manual testing confirms both sims function correctly in the browser

[DaveAlessi]

Additional Changes (Latest Commit)

Based on discord feedback, I've addressed two additional issues:

Spell Implementation Fixes:

1. Exorcism (sim/paladin/exorcism.go)

   • Updated spell IDs from SoD (415068-415073) to correct Classic IDs (879, 5614, 5615, 10312, 10313, 10314)
   • Double checked all the spell values like min damage, max damage, mana cost, scaling etc.
   • Added ExtraCastCondition to restrict casting to Demons/Undead only (correct Classic behavior)
   • Removed Demon + Undead crit bonus that was SoD only

2. Avenging Wrath (sim/paladin/paladin.go)

   • Removed registerAvengingWrath() from Initialize()
   • also removed the avenging_wrath.go file

Checklist Verified:

• Removed SoD stuff
• Checked spell implementations
• Checked class items/tier sets
• Presets (gear, talents, APL) (I'll give myself a half check here. The APLs are basic and the gear sets could use some work, I'll come back to it in a future PR)
• stats seem fine?

All tests pass and I tested the UI locally

[DaveAlessi]

Fixed Variable Naming

Several item set variables in item_sets_pve.go were incorrectly named after different armor sets. Renamed all variables to match their actual set names:

• ItemSetVestmentsOfProphecy → ItemSetLawbringerArmor
• ItemSetSoulforgeArmor → ItemSetJudgementArmor
• ItemSetConfessorsRaiment → ItemSetFreethinkersArmor
• ItemSetGarmentsOfTheOracle → ItemSetAvengersBattlegear
• ItemSetVestmentsOfFaith → ItemSetRedemptionArmor

Added Missing Set: Battlegear of Eternal Justice

Implemented the complete set with 3-piece bonus:

• 3pc: 20% chance to regain 100 mana when casting Judgement of Command or Righteousness
• Uses OnCastComplete callback with proper mana metrics

Fixed Lightforge Armor Set Implementation

Updated the 6-piece bonus (Crusader's Wrath proc) to use Classic vanilla mechanics:

• Changed from fixed ProcChance: 0.06 (SoD rate) to PPM: 3 (Classic vanilla rate)(Source 1: https://server.masterwow.cz/masterhead/?spell=27498, Source 2: https://wowgaming.altervista.org/aowow//?spell=27498)
• Changed ProcMask from ProcMaskMeleeWhiteHit to ProcMaskMelee. Most on melee attack procs can also trigger off SoR or SoC yellow hit, all enchants for example.
• Fixed redundant ActionID declaration

Updated Top Left Nav

Updated the top left corner drop down to choose different sims. Prot and Ret pal now show there.

Minor Edit to Ret APL

I understand twisting slightly better now so made a tweak to the APL.

---

Testing: Tested the additions manually in locally run server from local browser and also with make-test

• Had to run update-tests due to APL change

[1337LutZ]

https://wago.tools/db2/SpellAuraOptions?build=1.15.8.66129&filter%5BSpellID%5D=27498&page=1
Shows as 4 which is only White hits:

[1337LutZ]

Handy sheet: https://docs.google.com/spreadsheets/d/1I1qDV-TkpoE0YUe9h3aiYdgpG8biDb1nWx3TTM-0f9w/copy