Adjust EquipmentSpec initialization for TBC#62
Open
xeropresence wants to merge 1 commit intowowsims:mainfrom
Open
Adjust EquipmentSpec initialization for TBC#62xeropresence wants to merge 1 commit intowowsims:mainfrom
xeropresence wants to merge 1 commit intowowsims:mainfrom
Conversation
Modify EquipmentSpec creation logic for TBC version.
1337LutZ
reviewed
Mar 4, 2026
|
|
||
| local equipment = nil; | ||
| if Env.IS_CLASSIC_TBC then | ||
| equipment = setmetatable({ items = items}, EquipmentSpecMeta) |
Contributor
There was a problem hiding this comment.
This only fixes it for the Old Sim. This change can potentially break the new TBC Sim if there's Proto changes introduced.
EDIT: I was wrong, this version property isn't even used anymore
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modify EquipmentSpec creation logic for TBC version.