fix(api): bound Fiber probes and synchronize shutdown - #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked Issue
Fixes #9
Summary
Required Format
fix/.Scope And Project Status
Protocol, Safety, And Compatibility
This intentionally removes the unreleased callback-based readiness API and the probe body-size setting. The repository has no released runtime or users, so no compatibility shim or migration path is retained. Rollback is the single commit if the adapter must be restored before node composition exists.
Validation
git diff --checkpython3 scripts/check_docs.pygo mod verifyandgo mod tidy -diffgo vet ./...go test -count=1 -mod=readonly ./...go test -race -count=1 -mod=readonly ./...python3 scripts/check_go_architecture.py-trimpathgo test -race -run 'TestShutdownDuringStartupPreventsServing|TestConcurrentShutdownWaitsForOneServeExit' -count=100 ./pkg/api/httpserverProtocol vectors, Byzantine models, storage recovery, snapshots, chaos, and performance benchmarks are not applicable because this PR changes only the unreleased operational health adapter and adds no protocol, storage, consensus, or business request path.
Risk And Rollback
The lifecycle state machine and shared shutdown completion are the main implementation risk. Deterministic gated-listener tests, active-request drain tests, repeated stress under the race detector, and real loopback tests cover the relevant interleavings. Revert commit
b1c344fto restore the previous bootstrap adapter; no persisted data, wire schema, or migration is involved.