This repository was archived by the owner on Mar 1, 2024. It is now read-only.
Open
Conversation
added 2 commits
February 2, 2018 10:14
The plugin previosuly relied on `mysql_error` which was deprecated in 5.5 and completely removed in 7 in favor of the MySQL Improved extension. Regardless, WordPress provides a method of retrieving the last MySQL error that is interface agnostic, `$wpdb->last_error`. By using this functionality, the plugin no longer needs to be concerned with implementation details instead delegating that responsibility to WordPress Core.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support for the
mysql_*functions was deprecated in 5.5 and removed entirely in 7. This patch replaces a single call tomysql_error()with$wpdb->last_error, delegating the DBI work to WordPress core.