feat: finalize_integers()#18
Merged
Merged
Conversation
Co-authored-by: jonthegeek <33983824+jonthegeek@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add finalize_doubles() function to downcast double columns
feat: finalize_doubles()
Mar 10, 2026
jonthegeek
requested changes
Mar 10, 2026
Contributor
jonthegeek
left a comment
There was a problem hiding this comment.
@copilot Fix these issues.
Co-authored-by: jonthegeek <33983824+jonthegeek@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Adds a new exported helper finalize_integers() to downcast integerish columns/elements to integer for storage efficiency, wiring it into the package with docs, tests, and metadata updates.
Changes:
- Implement
finalize_integers()usingstbl::is_int_ish()+stbl::to_int()with input validation viastbl::pkg_abort(). - Add a dedicated
testthatfile covering conversion behavior, class preservation, and error classes. - Update package metadata/docs:
DESCRIPTION(version/R dependency/stbl import + remote),NAMESPACE,NEWS.md, and generated Rd files.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| R/finalize_integers.R | New exported function implementation + roxygen docs. |
| tests/testthat/test-finalize_integers.R | New test coverage for conversion, lists, NA handling, class preservation, and errors. |
| man/finalize_integers.Rd | Generated documentation for the new function. |
| DESCRIPTION | Version bump; adds R (>= 4.1), stbl import, and remote. |
| NAMESPACE | Exports finalize_integers(). |
| NEWS.md | Adds a user-facing entry for the new feature. |
| man/datawrap-package.Rd | Minor generated reordering in useful links. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
jonthegeek
approved these changes
Mar 10, 2026
Contributor
jonthegeek
left a comment
There was a problem hiding this comment.
Looks good as long as checks pass!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
stbltoImportsinDESCRIPTIONRemotes: stbl=wranglezone/stbltoDESCRIPTIONtests/testthat/test-finalize_integers.Rwith testsR/finalize_integers.Rwith implementationroxygen2::roxygenise()to update NAMESPACEair format .NEWS.mdentrypurrr::map()instead oflapply()in implementationstbl::pkg_abort()input validation for non-data.frame inputstbl::pkg_abort()error usingstbl::expect_pkg_error_classes()Note: After development, the function was changed from
finalize_doubles()tofinalize_integers(), so some of the notes seem incorrect now.Original prompt
🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.