-
Notifications
You must be signed in to change notification settings - Fork 0
Implement specify_fct()
#34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,2 +1,4 @@ | ||
| # Generated by roxygen2: do not edit by hand | ||
|
|
||
| export(specify_fct) | ||
| if (getRversion() < "4.3.0") importFrom("S7", "@") |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| # Developer note: `specify_fct()` is designed to create a data-less | ||
| # "specification" object. It defines the target state (the levels) for a factor | ||
| # but doesn't hold any actual factor data itself. This is why the constructor | ||
| # internally provides `integer()` as the data component to `S7::new_object()`. | ||
| # | ||
| # In the future, we might use the `hrmn_fct` class to represent actual, | ||
| # harmonized factor data. In that scenario, we would likely create a separate | ||
| # `class_hrmn_fct` object and have `specify_fct()` be a wrapper function that | ||
| # calls the constructor with the empty data. For now, since we don't need the | ||
| # full factor-like class, we are directly defining the `hrmn_fct` class in | ||
| # `specify_fct()` | ||
|
|
||
| #' Specify a factor harmonization | ||
| #' | ||
| #' Create a `hrmn_fct` object that specifies the desired levels for a factor | ||
| #' variable. This 'specification' object does not contain any data itself, only | ||
| #' the rules for harmonization. | ||
| #' | ||
| #' @param levels (`character`) The allowed values of the factor. | ||
| #' @returns A factor specification, an S7 object of class `hrmn::hrmn_fct`. | ||
| #' @export | ||
| specify_fct <- S7::new_class( | ||
| "hrmn_fct", | ||
| parent = S7::class_factor, | ||
| properties = list( | ||
| levels = S7::class_character | ||
| ), | ||
| constructor = function(levels = character()) { | ||
| S7::new_object( | ||
| integer(), | ||
| levels = levels | ||
| ) | ||
| } | ||
| ) | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| # enable usage of <S7_object>@name in package code | ||
| #' @rawNamespace if (getRversion() < "4.3.0") importFrom("S7", "@") | ||
| NULL |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| test_that("specify_fct() returns an object with the correct class", { | ||
| spec <- specify_fct() | ||
| expect_s3_class( | ||
| spec, | ||
| c("hrmn::hrmn_fct", "factor", "S7_object"), | ||
| exact = TRUE | ||
| ) | ||
| }) | ||
|
|
||
| test_that("specify_fct() stores the levels", { | ||
| lvls <- c("a", "b", "c") | ||
| spec <- specify_fct(levels = lvls) | ||
| expect_equal(spec@levels, lvls) | ||
| }) |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.