Remove a scratch file an audit agent left in the tree - #35
Merged
Conversation
`scratch_edited.md` is a copy of docs/ASVS-ASSESSMENT.md that an audit subagent wrote while probing whether a checker would catch a planted defect. It was told to delete it and did not. My `git add -A` in #34 swept it into the commit, and `test_internal_links_resolve` immediately caught it: the copy sits at the repository root, so its relative link to `standards/OVERVIEW.md#the-files` resolves against the wrong directory and points at nothing. THE GATE DID ITS JOB AND I DID NOT. Both gate runs on #34 went red and said exactly this, and I merged anyway -- `gh pr checks` printed the failures and I read the `MERGED` line under them rather than the two `fail` lines above it. Nothing about the merge was forced; I simply did not look. The checks were advisory to me at the moment they were least advisory. Two things follow, and neither is "be more careful". `git add -A` after an agent has been running in the worktree stages whatever it left behind, so the staging step has to be specific about paths or the tree has to be verified clean first. And a merge should read the check conclusions rather than the merge result, because the merge result is the one line that is green whatever the checks said. Main is red until this lands. 146 tests pass with it removed. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main is red. This fixes it.
scratch_edited.mdis a copy ofdocs/ASVS-ASSESSMENT.mdthat an audit subagent wrote while probingwhether a checker would catch a planted defect. It was instructed to delete it and did not. My
git add -Ain #34 swept it into the commit.test_internal_links_resolvecaught it instantly: the copy sits at the repository root, so itsrelative link to
standards/OVERVIEW.md#the-filesresolves against the wrong directory.The gate did its job and I did not
Both gate runs on #34 went red and said exactly this. I merged anyway —
gh pr checksprintedthe failures and I read the
MERGEDline beneath them instead of the twofaillines above it.Nothing was forced; I just didn't look.
Two things follow, and neither is "be more careful":
git add -Aafter an agent has run in the worktree stages whatever it left behind. The stagingstep has to name paths, or the tree has to be verified clean first.
line that comes back green whatever the checks said.
146 tests pass with the file removed.
🤖 Generated with Claude Code