Skip to content

Disable auto-release for SDK workflows#2772

Merged
renuka-fernando merged 1 commit into
wso2:mainfrom
SavinduDimal:sdk-auto-release-disable
Jul 21, 2026
Merged

Disable auto-release for SDK workflows#2772
renuka-fernando merged 1 commit into
wso2:mainfrom
SavinduDimal:sdk-auto-release-disable

Conversation

@SavinduDimal

Copy link
Copy Markdown
Contributor

Purpose

  • $Subject

@coderabbitai

coderabbitai Bot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

The three SDK release workflows are now manual-only. Their manual version inputs remove an optional leading v and must match the strict MAJOR.MINOR.PATCH format before release processing continues.

Changes

SDK release workflow controls

Layer / File(s) Summary
Manual release triggering
.github/workflows/sdk-ai-release.yml, .github/workflows/sdk-core-release.yml, .github/workflows/sdk-release.yml
Push-based releases from main are removed, leaving manual workflow_dispatch releases.
Manual version input validation
.github/workflows/sdk-ai-release.yml, .github/workflows/sdk-core-release.yml, .github/workflows/sdk-release.yml
Manual versions are passed through environment variables, normalized for an optional leading v, and validated as MAJOR.MINOR.PATCH before tagging or pushing.

Estimated code review effort: 2 (Simple) | ~15 minutes

Suggested reviewers: pubudu538, renuka-fernando, thushani-jayasekera

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description only includes a placeholder purpose and omits the required template sections. Replace the placeholder with full Purpose, Goals, Approach, User stories, Documentation, Tests, Security checks, Samples, Related PRs, and Test environment details.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the main change: disabling automatic SDK releases.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@SavinduDimal

Copy link
Copy Markdown
Contributor Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
.github/workflows/sdk-ai-release.yml (1)

32-39: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win

Remove dead code for the disabled push trigger.

Since these workflows are now manual-only, the push trigger's auto-increment logic is unreachable. The if [ "${{ github.event_name }}" = "workflow_dispatch" ]; then conditional and its corresponding else block can be safely removed to simplify the script.

  • .github/workflows/sdk-ai-release.yml#L32-L39: Remove the if condition and the else block containing the auto-increment logic, keeping only the manual version validation un-indented.
  • .github/workflows/sdk-core-release.yml#L32-L39: Remove the if condition and the else block containing the auto-increment logic, keeping only the manual version validation un-indented.
  • .github/workflows/sdk-release.yml#L32-L39: Remove the if condition and the else block containing the auto-increment logic, keeping only the manual version validation un-indented.
♻️ Example refactor for the `Determine version` run block
# Use provided version (read from env, remove leading 'v' if present)
VERSION="${INPUT_VERSION#v}"

# Validate strict semantic version (MAJOR.MINOR.PATCH) before it reaches any tag/push command
if ! printf '%s' "$VERSION" | grep -Eq '^[0-9]+\.[0-9]+\.[0-9]+$'; then
  echo "Error: provided version is not a valid semantic version (expected MAJOR.MINOR.PATCH, e.g. 0.3.10)"
  exit 1
fi

echo "Using manually provided version: ${VERSION}"
echo "version=${VERSION}" >> $GITHUB_OUTPUT
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.github/workflows/sdk-ai-release.yml around lines 32 - 39, Remove the
unreachable workflow_dispatch conditional and push-trigger auto-increment else
branch from the Determine version run block in
.github/workflows/sdk-ai-release.yml (lines 32-39),
.github/workflows/sdk-core-release.yml (lines 32-39), and
.github/workflows/sdk-release.yml (lines 32-39). Keep the manual INPUT_VERSION
normalization and semantic-version validation directly in each script,
unindented, followed by the existing output behavior.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In @.github/workflows/sdk-ai-release.yml:
- Around line 32-39: Remove the unreachable workflow_dispatch conditional and
push-trigger auto-increment else branch from the Determine version run block in
.github/workflows/sdk-ai-release.yml (lines 32-39),
.github/workflows/sdk-core-release.yml (lines 32-39), and
.github/workflows/sdk-release.yml (lines 32-39). Keep the manual INPUT_VERSION
normalization and semantic-version validation directly in each script,
unindented, followed by the existing output behavior.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 51469ee6-33d6-4f1c-bebc-866c515fab7b

📥 Commits

Reviewing files that changed from the base of the PR and between 25a0178 and c070f10.

📒 Files selected for processing (3)
  • .github/workflows/sdk-ai-release.yml
  • .github/workflows/sdk-core-release.yml
  • .github/workflows/sdk-release.yml

@renuka-fernando
renuka-fernando merged commit ca46001 into wso2:main Jul 21, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants