Disable auto-release for SDK workflows#2772
Conversation
📝 WalkthroughWalkthroughThe three SDK release workflows are now manual-only. Their manual version inputs remove an optional leading ChangesSDK release workflow controls
Estimated code review effort: 2 (Simple) | ~15 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai review |
✅ Action performedReview finished.
|
There was a problem hiding this comment.
🧹 Nitpick comments (1)
.github/workflows/sdk-ai-release.yml (1)
32-39: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winRemove dead code for the disabled push trigger.
Since these workflows are now manual-only, the
pushtrigger's auto-increment logic is unreachable. Theif [ "${{ github.event_name }}" = "workflow_dispatch" ]; thenconditional and its correspondingelseblock can be safely removed to simplify the script.
.github/workflows/sdk-ai-release.yml#L32-L39: Remove theifcondition and theelseblock containing the auto-increment logic, keeping only the manual version validation un-indented..github/workflows/sdk-core-release.yml#L32-L39: Remove theifcondition and theelseblock containing the auto-increment logic, keeping only the manual version validation un-indented..github/workflows/sdk-release.yml#L32-L39: Remove theifcondition and theelseblock containing the auto-increment logic, keeping only the manual version validation un-indented.♻️ Example refactor for the `Determine version` run block
# Use provided version (read from env, remove leading 'v' if present) VERSION="${INPUT_VERSION#v}" # Validate strict semantic version (MAJOR.MINOR.PATCH) before it reaches any tag/push command if ! printf '%s' "$VERSION" | grep -Eq '^[0-9]+\.[0-9]+\.[0-9]+$'; then echo "Error: provided version is not a valid semantic version (expected MAJOR.MINOR.PATCH, e.g. 0.3.10)" exit 1 fi echo "Using manually provided version: ${VERSION}" echo "version=${VERSION}" >> $GITHUB_OUTPUT🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In @.github/workflows/sdk-ai-release.yml around lines 32 - 39, Remove the unreachable workflow_dispatch conditional and push-trigger auto-increment else branch from the Determine version run block in .github/workflows/sdk-ai-release.yml (lines 32-39), .github/workflows/sdk-core-release.yml (lines 32-39), and .github/workflows/sdk-release.yml (lines 32-39). Keep the manual INPUT_VERSION normalization and semantic-version validation directly in each script, unindented, followed by the existing output behavior.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In @.github/workflows/sdk-ai-release.yml:
- Around line 32-39: Remove the unreachable workflow_dispatch conditional and
push-trigger auto-increment else branch from the Determine version run block in
.github/workflows/sdk-ai-release.yml (lines 32-39),
.github/workflows/sdk-core-release.yml (lines 32-39), and
.github/workflows/sdk-release.yml (lines 32-39). Keep the manual INPUT_VERSION
normalization and semantic-version validation directly in each script,
unindented, followed by the existing output behavior.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 51469ee6-33d6-4f1c-bebc-866c515fab7b
📒 Files selected for processing (3)
.github/workflows/sdk-ai-release.yml.github/workflows/sdk-core-release.yml.github/workflows/sdk-release.yml
Purpose