Skip to content

[Bug fix] get inherited resources in preference endpoint - #1153

Merged
ZiyamSanthosh merged 1 commit into
wso2:masterfrom
raviendalpatadu:preference/endpoint
Jul 22, 2026
Merged

[Bug fix] get inherited resources in preference endpoint#1153
ZiyamSanthosh merged 1 commit into
wso2:masterfrom
raviendalpatadu:preference/endpoint

Conversation

@raviendalpatadu

Copy link
Copy Markdown
Contributor

@coderabbitai

coderabbitai Bot commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 0952e376-29e9-4373-95eb-38dc7a210357

📥 Commits

Reviewing files that changed from the base of the PR and between c056803 and ed77c0f.

📒 Files selected for processing (1)
  • components/org.wso2.carbon.identity.api.server.configs/org.wso2.carbon.identity.api.server.configs.v1/src/main/java/org/wso2/carbon/identity/api/server/configs/v1/core/ServerConfigManagementService.java

📝 Walkthrough

Summary

Updated the preference endpoint to retrieve inherited configuration resources while preserving existing fallback behavior for default resources and 404 responses.

Walkthrough

Updated resolveConfigResource to call configurationManager.getResource with an additional true argument. Existing fallback behavior for missing configuration-store resources and missing default resolvers remains unchanged.

Suggested reviewers: hwupathum

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description only lists an issue and related PR; it omits most required template sections like purpose, goals, approach, tests, and release note. Fill in the template sections with purpose, goals, approach, user stories, checklist, release note, docs, tests, and other applicable fields.
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: fetching inherited resources in the preference endpoint.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@jenkins-is-staging

Copy link
Copy Markdown

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/29892032556

@jenkins-is-staging

Copy link
Copy Markdown

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/29892032556
Status: success

@jenkins-is-staging jenkins-is-staging left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/29892032556

@ZiyamSanthosh
ZiyamSanthosh merged commit e27d880 into wso2:master Jul 22, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants