Open
Conversation
* update nvmrc to use the carbon tag, update the vjs karma tool * update npm-run-all to 4.1.5 * http to https
…egment (videojs#98) The default value for EXT-X-BYTERANGE is defined by the spec as the first byte after the previous segment. Prior to this change, the default set by m3u8-parser was 0.
…ts, unify byterange handling (videojs#137)
|
@benburkhart1 would you be able to review this? Noticed in QA setup that stream-toolkit nom install fails with master branch of m3u8-parser while this PR fixes that. |
Just adding on; we ran into this issue when attempting to get stream-toolkit to run on an EC2 instance. It was failing because of the jsdoc dependency issue. Here is an example of how videojs handled this issue: https://github.com/videojs/videojs-contrib-eme/pull/162/files |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@benburkhart1 I've updated from upstream to fix issues when using stream-toolkit as a dependency