Skip to content

pipe: Fix fastq chunking bugs.#287

Merged
wwood merged 1 commit intomainfrom
fastq_chunks_fix
Mar 17, 2026
Merged

pipe: Fix fastq chunking bugs.#287
wwood merged 1 commit intomainfrom
fastq_chunks_fix

Conversation

@wwood
Copy link
Owner

@wwood wwood commented Mar 17, 2026

No description provided.

@wwood wwood merged commit 3e1461b into main Mar 17, 2026
4 checks passed
@wwood wwood deleted the fastq_chunks_fix branch March 17, 2026 02:15
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f578e271d6

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines 105 to +107
if base.endswith('.gz'):
base = base[:-3]
if base.endswith(('.fq', '.fastq')):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Support zstd filenames when inferring chunk input format

prepare_chunking_fifos now strips only .gz before checking FASTA/FASTQ suffixes, so non-.gz compressed names fall through to the new exception path. In SearchPipe.run, chunking is applied after prepare_zstd_fifos, which renames zstd inputs to FIFOs like *.zst.fifo; with --read-chunk-size/--read-chunk-number, these files no longer match the FASTA/FASTQ suffix checks and the pipeline aborts instead of chunking reads. This introduces a regression for chunked zstd input workflows.

Useful? React with 👍 / 👎.

@wwood wwood restored the fastq_chunks_fix branch March 17, 2026 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant