Skip to content

Fastq chunks fix#289

Open
wwood wants to merge 3 commits intomainfrom
fastq_chunks_fix
Open

Fastq chunks fix#289
wwood wants to merge 3 commits intomainfrom
fastq_chunks_fix

Conversation

@wwood
Copy link
Owner

@wwood wwood commented Mar 17, 2026

No description provided.

@wwood wwood force-pushed the fastq_chunks_fix branch from bf15f19 to b6da26e Compare March 17, 2026 06:07
@chatgpt-codex-connector
Copy link

💡 Codex Review

raise Exception(f"Cannot determine format (FASTA or FASTQ) for chunking from file extension: {path}")

P2 Badge Preserve chunking for extensionless streamed inputs

The new format check in prepare_chunking_fifos now hard-fails when the path does not end in .fa/.fasta/.fna/.fq/.fastq after suffix stripping, which regresses chunking for valid streamed inputs such as FIFOs or process-substitution paths (for example /dev/fd/*) that often have no extension. Before this commit those inputs were still chunked (as FASTA semantics), but now --read-chunk-size/--read-chunk-number aborts immediately even when the underlying data is valid, breaking chunked workflows that rely on extensionless paths.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

wwood and others added 2 commits March 17, 2026 18:16
When DIAMOND fails, terminate any running zstd/chunking background
processes (gzip -dc, awk) immediately so they don't block on writing
to a FIFO that nobody is reading. finish_processes now tolerates
negative return codes (signal-killed processes).

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant