Open
Conversation
Contributor
joaquinco
commented
Sep 18, 2024
joaquinco
commented
- Add a time throttling mechanism to prevent multiple errors to trigger notifications. It works by scheduling a notification after the last error until :throttle milliseconds have passed without an error or :time_limt milliseconds have passed from the first occurrence.
joaquinco
force-pushed
the
feature/time-grouping
branch
from
2d8eb8f to
02422c0
Compare
Fix test that was not detecting this
joaquinco
force-pushed
the
feature/time-grouping
branch
from
02422c0 to
51cfb59
Compare
iaguirre88
reviewed
Dec 9, 2024
Member
iaguirre88
left a comment
iaguirre88
left a comment
There was a problem hiding this comment.
Great work 💪
Just left some questions
|
|
||
| use BoomNotifier, | ||
| notification_trigger: [:exponential], | ||
| count: [:exponential], |
Member
There was a problem hiding this comment.
Even though I like this name better I'd rather not to introduce api changes in this pull request
I think before releasing v1.0.0 we should revisit the whole api and address the changes in a separate PR
| notifiers: [ | ||
| # ... | ||
| ], | ||
| groupping: :time, |
Member
There was a problem hiding this comment.
Does it makes sense to have :time as other notification_trigger strategy instead of adding a new option? And maybe we could use the same time limit key we use for the others
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.