Skip to content

[feature] Implement scrollable page list#850

Open
amiralimollaei wants to merge 1 commit into
xCollateral:devfrom
amiralimollaei:pr/scrollable-video-pages-list
Open

[feature] Implement scrollable page list#850
amiralimollaei wants to merge 1 commit into
xCollateral:devfrom
amiralimollaei:pr/scrollable-video-pages-list

Conversation

@amiralimollaei

@amiralimollaei amiralimollaei commented Jun 22, 2026

Copy link
Copy Markdown

This PR refactors the options screen GUI by extracting scrolling code from VOptionList into a new abstract base class AbstractScrollList, and replacing the page button layout in VOptionScreen with a dedicated, scrollable VPageList gui element.

Warning

I used Deepseek for parts of this PR, seems easy enough that even AI can do it, that doesn't mean it's wrong, I've verified the code manually.

Checklist

  • This PR doesn't break already existing mods that register to the Video Options GUI
  • Verified that the options list scrolling feels identical to pre-refactor behavior.
  • Verified that the new page sidebar scrolls correctly when populated with a high volume of mod entries.
  • Ensured scissor clipping bounds are accurate and don't bleed into adjacent UI elements.

@amiralimollaei amiralimollaei changed the title Refactor VOptionList & VPageList — Extract shared scrolling, implement scrollable page list [feature] Implement scrollable page list Jun 22, 2026
widget.setFocused(bl);
}
}
} No newline at end of file

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved from VOptionList, to be shared with VPagesList

@amiralimollaei amiralimollaei marked this pull request as ready for review June 22, 2026 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant