test: add fail-closed path-aware test selection#2
Open
elixlabssolutions wants to merge 7 commits into
Open
Conversation
elixlabssolutions
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intent
Implement Phase 1 fail-closed Firstmate test selection with focused local feedback and one complete no-mistakes backstop.
What Changed
mainand rungate-shadow, which always retains one complete-suite backstop.Risk Assessment
✅ Low: The updated documentation accurately describes the trusted selector and complete-suite gate backstop, and the reviewed implementation remains narrowly fail-closed.
Testing
The supplied baseline full suite had passed; I ran the selector contract suite and captured real CLI receipts for focused gate-shadow and the configured no-mistakes loader, both showing focus followed by a complete passing backstop. The exact target correctly chose a complete fallback for its selector self-change and emitted a stable failure receipt for four flaky existing tests; all four passed on immediate retry.
Evidence: Selector contract suite
Evidence: Focused gate-shadow CLI receipt
Evidence: Configured no-mistakes loader receipt
Evidence: Exact-target fail-closed fallback receipt
Pipeline
Updates from git push no-mistakes
✅ **intent** - passed
✅ No issues found.
✅ **Rebase** - passed
✅ No issues found.
🔧 **Review** - 1 issue found → auto-fixed ✅
docs/configuration.md:106- The gate documentation now sayscommands.testruns the behavior suite “directly,” but the changed command clones targetmain, loads its selector, and runsgate-shadow. This hides the trusted-policy/network fail-closed behavior operators need to understand; restore an accurate description of the selector loader and complete-suite backstop.🔧 Fix: Captain: clarify fail-closed gate documentation
✅ Re-checked - no issues remain.
command -v tmux >/dev/null || { echo "tmux is required for e2e tests" >&2; exit 1; }; tmux -V; rc=0; for t in tests/*.test.sh; do echo "== $t =="; bash "$t" || rc=1; done; exit "$rc"Baseline supplied as passed:command -v tmux >/dev/null || { echo "tmux is required for e2e tests" >&2; exit 1; }; tmux -V; rc=0; for t in tests/*.test.sh; do echo "== $t =="; bash "$t" || rc=1; done; exit "$rc"bash tests/fm-test-select.test.shIsolatedbash bin/fm-test-select.sh gate-shadowon an eligible contract editIsolated configured.no-mistakes.yamlcommands.testloader executionbash bin/fm-test-select.sh localRetry:bash tests/fm-afk-inject-e2e.test.sh,bash tests/fm-backend-cmux.test.sh,bash tests/fm-backend-herdr.test.sh, andbash tests/fm-composer-lib.test.sh✅ **Document** - passed
✅ No issues found.
✅ **Lint** - passed
✅ No issues found.
✅ **Push** - passed
✅ No issues found.